actor.cpp, flyers.cpp, sewer.cpp: replace anim.state magic numbers ...#283
Merged
luciusDXL merged 6 commits intoluciusDXL:masterfrom Nov 1, 2024
Merged
actor.cpp, flyers.cpp, sewer.cpp: replace anim.state magic numbers ...#283luciusDXL merged 6 commits intoluciusDXL:masterfrom
anim.state magic numbers ...#283luciusDXL merged 6 commits intoluciusDXL:masterfrom
Conversation
Owner
|
Looks good so far, I will merge once I spend more time making sure the numbers match. :) |
…RN, as aliases for 1U and 2U. these are now used by the Thinker module in actor.cpp
…flyers.cpp instead of STATE_ANIMATEATTACK
jerethk
reviewed
Nov 1, 2024
| STATE_MOVE = 1u, | ||
| // Update our destination (generally moving towards the player). | ||
| STATE_TURN = 2u, | ||
| }; |
Contributor
There was a problem hiding this comment.
@kevinfoley My opinion is that it would be cleaner, and more readable code if we just make a separate enum
So change the existing LogicAnimState to LogicAttackAnimState (or something like that)
and add a LogicThinkerAnimState with MOVE and TURN
Contributor
There was a problem hiding this comment.
as discussed in Discord - this won't work because both modules use the same struct
Please ignore :-)
Contributor
|
@kevinfoley looks like you also need to make a change in the |
luciusDXL
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…with explicit enum values